Skip to content

Conversation

@nicholaspai
Copy link
Member

Issue:

  • [N01] Missing link to referenced code
    • Within the Ethereum_Adapter, there is a mention of copying code from "Governor.sol". It appears that
      the contract in question is Governor.sol from the UMAprotocol/protocol repository.
    • Since it is a part of a separate repository, and it is possible that the code may change in the future,
      consider including a link to the file, including a commit hash, so that it can be easily referenced by
      developers and reviewers in the future.

@nicholaspai nicholaspai added the OZ Audit - March Resolves issue discovered in March 2022 OZ Audit label Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OZ Audit - March Resolves issue discovered in March 2022 OZ Audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants